Pin the launch runtime in TUI docker-gate tests - #57
Merged
Conversation
The startup gate branches on the backend runtime (docker -> StartContainersScreen, process -> StartBackendProcessScreen), but the container-path tests never pinned it, so they read the developer's own BACKEND_RUNTIME or saved choice. On a machine configured for process — possible since the sandbox-without-docker work — three of them asserted the wrong branch and failed. Adds a _docker_runtime() helper next to the existing _gate_ready(), marking the runtime explicitly configured (so the infer-from-what's-running block, which probes the real host for a backend process, is skipped) and resolving it to docker. Applied to all five container-path tests, including the two that only passed by accident. Verified green with BACKEND_RUNTIME unset, =process and =docker.
akozak-gd
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three
TestStartupGatetests fail onmainfor anyone whose local backend runtime isprocess.Root cause. The startup gate branches on the backend runtime — docker →
StartContainersScreen, process →StartBackendProcessScreen— but the container-path tests never pinned it, soresolve_backend_runtime()read the developer's ownBACKEND_RUNTIME/ saved choice. Since the sandbox-without-docker work madeprocessa real option, those tests started asserting the wrong branch. They were never docker-specific by construction, only by the environment they happened to run in.Fix. A
_docker_runtime()helper alongside the existing_gate_ready(), which both resolves the runtime to docker and marks it explicitly configured — the latter matters because otherwise the gate falls into its infer-from-what's-running block and probes the real host for a backend process. Applied to all five container-path tests, not just the three that were red:test_start_no_quits_app(quits whatever screen is up) andtest_backend_not_ready_retry_skips_compose_up(start_containersis trivially never awaited on the process path) were passing for the wrong reason.No production code touched.
Verification.
make unit-testsgreen. The gate tests pass withBACKEND_RUNTIMEunset,=processand=docker, which is the property that was missing.